[ONNX] Improve ONNX delegate quality #32463
Merged
+45
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: ONNX FE
Signed-off-by: Maxim Vafin <maxim.vafin@intel.com>
bumbosiepsak
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the ONNX delegate by adding support for string constants, fixing the opset version handling for the ai.onnx domain, and improving error handling when model files cannot be read.
Key changes:
- Added support for string constant tensors through new
m_tensor_data_anyfield - Fixed opset version resolution to correctly handle the
ai.onnxdomain mapping - Improved error messages and exception handling for file reading failures
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontends/onnx/tests/onnx_importer_test.cpp | Fixed typo in test error message |
| src/frontends/onnx/frontend/src/input_model.cpp | Refactored constructor delegation and added m_tensor_data_any parameter |
| src/frontends/onnx/frontend/src/core/tensor.hpp | Added m_tensor_data_any field and getter to support string constants |
| src/frontends/onnx/frontend/src/core/tensor.cpp | Implemented string data extraction and constant creation for string tensors |
| src/frontends/onnx/frontend/src/core/node.cpp | Updated tensor place construction to include m_tensor_data_any |
| src/frontends/onnx/frontend/src/core/graph_iterator_proto.cpp | Fixed opset version logic, improved error handling, and added string data extraction |
| src/frontends/onnx/frontend/src/core/decoder_proto.hpp | Simplified domain handling by removing special case for ai.onnx |
| src/frontends/onnx/frontend/include/openvino/frontend/onnx/decoder.hpp | Added m_tensor_data_any field to TensorMetaInfo struct |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged
via the queue into
openvinotoolkit:master
with commit Oct 20, 2025
8f23526
210 of 212 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
ai.onnxdomainTickets: